Disable Field count validation of CSV viewer #35228
Conversation
Default behaviour rejected all rows (Records) with more or fewer columns (Fields) than the first row, preventing them from rendering at all and silently hiding them.
GiteaBot
added
the
lgtm/need 2
|
Unit tests need to be updated/extended: |
|
I see that test case ( |
GiteaBot
added
lgtm/need 1
|
What will happen to CSV file comparisons after this change? |
The missing columns seem to already be empty cells, perhaps because the comparison code already needed to handle changing number of columns. Personally I find the side-by-side rendered diff to be too confusing to read and am thinking about doing row-by-row comparisons. |
|
Yeah, row-based diff would be similar to git diff and likely more readable. Probably better to split that out into another PR. |
Default behaviour rejected all rows (Records) with more or fewer columns (Fields) than the first row, preventing them from parsing at all and silently hiding them. While RFC4180 section 2.4 says each line should contain the same number of fields, enforcing this on the viewer is unhelpful.
This pull request disables that validation, allowing the viewer to render lines with fewer columns than the maximum number within the file. As it's a simple HTML table, this works without additional changes (i.e. no need to manually determine the maximum number of columns), but the default appearance of rows with fewer columns may be undesirable to some people, especially when using CSS that has
td {border-right: none}.Fixes #16559, #30358.
Unfortunately, retaining empty lines is less trivial, so the line numbers on the leftmost column will still not match the source file whenever those are present, though a future PR could address that.